Skip to content

[FC-0036] feat: Display Units Taxonomy Tags in drawer#33563

Merged
bradenmacdonald merged 4 commits intoopenedx:masterfrom
open-craft:yusuf-musleh/units-taxonomy-tags-drawer
Nov 8, 2023
Merged

[FC-0036] feat: Display Units Taxonomy Tags in drawer#33563
bradenmacdonald merged 4 commits intoopenedx:masterfrom
open-craft:yusuf-musleh/units-taxonomy-tags-drawer

Conversation

@yusuf-musleh
Copy link
Member

@yusuf-musleh yusuf-musleh commented Oct 23, 2023 •
edited
Loading

Description

This adds "Manage Tags" action in the units' dropdown that opens up a side drawer containing an iframe to the course authoring mfe that will handle the taxonomy tags UI for the unit.

Clicking outside the side drawer or on the x in the iframe closes the side drawer.

Supporting information

Related Tickets:

Related PRs:

Testing instructions

  1. Make sure you have the frontend-app-course-authoring repo cloned and checkout the branch of this PR [FC-0036] feat: Add ContentTagsDrawer widget frontend-app-authoring#654
  2. Start the frontend-app-course-authoring with npm start
  3. Checkout this PRs branch and run it in your devstack
  4. If you don't already have sample taxonomy/tags data, follow the instructions in this repo to generate sample data: https://github.com/open-craft/taxonomy-sample-data
  5. Navigate to studio to one of the sample course created in from the previous step: http://localhost:18010/course/course-v1:SampleTaxonomyOrg1+STC1+2023_1
  6. Locate a unit in the course outline page, and confirm that the there is no tags button showing in either the actions dropdown or next to it
  7. Next, navigate to http://localhost:18010/admin/waffle/flag/ and create a new flag: new_studio_mfe.use_tagging_taxonomy_list_page make sure it is active for everyone
  8. Navigate back to the course outline page, refresh it, you should see the tags button with a question mark (the count will be implemented in a later PR), along with the "Manage Tags" option in the actions dropdown.

Screen Shot 2023-11-08 at 3 53 53 PM

  1. Confirm that both methods open the side drawer with no issues
  2. Testing the drawer functionality is part of the testing instructions in the PR [FC-0036] feat: Add ContentTagsDrawer widget frontend-app-authoring#654

Private-ref: FAL-3523

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 23, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 23, 2023 •
edited
Loading

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh yusuf-musleh changed the title feat: Display Units Taxonomy Tags in drawer [WIP] feat: Display Units Taxonomy Tags in drawer Oct 23, 2023
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 0af988f to e6e5b3d Compare October 24, 2023 10:52
@yusuf-musleh yusuf-musleh changed the title [WIP] feat: Display Units Taxonomy Tags in drawer [WIP] [FC-0036] feat: Display Units Taxonomy Tags in drawer Oct 24, 2023
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from e6e5b3d to cda7147 Compare October 27, 2023 07:31
@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Oct 30, 2023
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from cda7147 to 03546a8 Compare November 1, 2023 16:21
@open-craft-grove
Copy link

open-craft-grove commented Nov 1, 2023

Sandbox deployment started.

@open-craft-grove
Copy link

open-craft-grove commented Nov 1, 2023

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 03546a8 to e1f9757 Compare November 2, 2023 08:24
@open-craft-grove
Copy link

open-craft-grove commented Nov 2, 2023

Sandbox deployment started.

@open-craft-grove
Copy link

open-craft-grove commented Nov 2, 2023

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

@open-craft-grove
Copy link

open-craft-grove commented Nov 2, 2023

Sandbox deployment started.

@open-craft-grove
Copy link

open-craft-grove commented Nov 2, 2023

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

@bradenmacdonald bradenmacdonald mentioned this pull request Nov 2, 2023
Merged
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 4494e90 to 9773d55 Compare November 3, 2023 07:53
bradenmacdonald
bradenmacdonald reviewed Nov 3, 2023
View reviewed changes
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 9773d55 to c4e1562 Compare November 5, 2023 11:07
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 7, 2023 •
edited
Loading

@yusuf-musleh Is this PR ready for review, or are you thinking it might change still? When it's ready, can you please update the description and mark it as non-draft?

@yusuf-musleh
feat: Add Units Taxonomy Tags drawer
4951a1f 
This adds "Manage Tags" action in the units' dropdown that opens up a
side drawer containing an iframe to the course authoring mfe that will
handle the taxonomy tags UI for the unit.

Clicking outside the side drawer or on the x in the iframe closes the
side drawer.
@yusuf-musleh
feat: Place manage tags behind waffle flag
2da7168 
Using the same existing ENABLE_TAGGING_TAXONOMY_LIST_PAGE flag.
@yusuf-musleh
test: Update failing test case
b3be8ab
@yusuf-musleh
feat: Auto focus on iframe when opened
8518acb
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 82be057 to 8518acb Compare November 8, 2023 12:37
@open-craft-grove
Copy link

open-craft-grove commented Nov 8, 2023

Sandbox deployment started.

@yusuf-musleh yusuf-musleh marked this pull request as ready for review November 8, 2023 13:00
@yusuf-musleh yusuf-musleh changed the title [WIP] [FC-0036] feat: Display Units Taxonomy Tags in drawer [FC-0036] feat: Display Units Taxonomy Tags in drawer Nov 8, 2023
@yusuf-musleh yusuf-musleh mentioned this pull request Nov 8, 2023
Merged
@yusuf-musleh
Copy link
Member Author

yusuf-musleh commented Nov 8, 2023

@yusuf-musleh Is this PR ready for review, or are you thinking it might change still? When it's ready, can you please update the description and mark it as non-draft?

@bradenmacdonald Just wrapped up the PR and its ready for your review!

@open-craft-grove
Copy link

open-craft-grove commented Nov 8, 2023

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

bradenmacdonald
bradenmacdonald approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: in Studio, with and without the feature flag
  • I read through the code
  • I checked for accessibility issues: yes, it's keyboard accessible
  • Includes documentation: n/a for now

@bradenmacdonald bradenmacdonald merged commit e311ef5 into openedx:master Nov 8, 2023
@bradenmacdonald bradenmacdonald deleted the yusuf-musleh/units-taxonomy-tags-drawer branch November 8, 2023 20:23
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 8, 2023

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@open-craft-grove
Copy link

open-craft-grove commented Nov 8, 2023

Sandbox update request received. Deployment will start soon.

1 similar comment
@open-craft-grove
Copy link

open-craft-grove commented Nov 8, 2023

Sandbox update request received. Deployment will start soon.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Nov 8, 2023

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Nov 8, 2023

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Nov 8, 2023

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Nov 8, 2023

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Nov 8, 2023

2U Release Notice: This PR has been deployed to the edX production environment.

@bradenmacdonald bradenmacdonald mentioned this pull request Nov 9, 2023
Merged
@andrey-canon andrey-canon mentioned this pull request May 7, 2024
Merged
andrey-canon pushed a commit to nelc/edx-platform that referenced this pull request May 15, 2024
@yusuf-musleh @andrey-canon
feat: Studio menu/button to display Unit's Tags (feature flagged) (op…
a5d7a37 
…enedx#33563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees

No one assigned

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yusuf-musleh @openedx-webhooks @open-craft-grove @bradenmacdonald @edx-pipeline-bot